On 21 July 2017 at 14:34, Daniel Stone <dani...@collabora.com> wrote:
> If the underlying driver does not support modifiers, dmabuf will still
> advertise formats through the 'modifier' event, but send them with an
> invalid modifier. Ignore them if this is the case, rather than passing
> them through to the driver.
>
> Signed-off-by: Daniel Stone <dani...@collabora.com>
> Fixes: 02cc35937277 ("egl/wayland: Use linux-dmabuf interface for buffers")
> ---
> src/egl/drivers/dri2/platform_wayland.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/egl/drivers/dri2/platform_wayland.c
> b/src/egl/drivers/dri2/platform_wayland.c
> index 211036f45f..7992717854 100644
> --- a/src/egl/drivers/dri2/platform_wayland.c
> +++ b/src/egl/drivers/dri2/platform_wayland.c
> @@ -370,6 +370,9 @@ get_back_bo(struct dri2_egl_surface *dri2_surf)
> return -1;
> }
>
> + if (num_modifiers == 0)
> + modifiers = NULL;
> +
AFAICT this hunk is not needed - modifiers is accessed only when
num_modifiers is non-zero.
With ^^ dropped, the patch is
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
-Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
