On Tuesday, July 25, 2017 9:49:22 AM PDT Lionel Landwerlin wrote:
> As Chris commented, it makes more sense to have batch buffer flushes
> before the query. Usually applications like frame_retrace do a series
> of queries and in that case, with flushes at the end of the queries,
> we might still have the first query contained in 2 different batchs.
> More generally it would be quite usual to have the query contained in
> 2 batch buffers because we never now what's the fill rate of the
> current batch buffer.
>
> If we move the flushing at the beginning of the queries, it's pretty
> much guaranteed that queries will be contained in a single batch
> buffer (unless the amount of commands is huge, but then it's only fair
> to include reloading request times in the measurements).
>
> Fixes: adafe4b733c02 ("i965: perf: minimize the chances to spread queries
> across batchbuffers")
> Reported-by: Chris Wilson <[email protected]>
> Signed-off-by: Lionel Landwerlin <[email protected]>
> Cc: 17.1 <[email protected]>17.2 branched, so: Cc: "17.1 17.2" <[email protected]> Reviewed-by: Kenneth Graunke <[email protected]>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
