Hi Chris, > -----Original Message----- > From: Chris Wilson [mailto:[email protected]] > Sent: Tuesday, August 1, 2017 2:35 PM > To: Marathe, Yogesh <[email protected]>; mesa- > [email protected] > Cc: Muthukumar, Aravindan <[email protected]> > Subject: RE: [Mesa-dev] [PATCH] i965: Avoids loop for buffer object > availability > in add_exec_bo > > Quoting Marathe, Yogesh (2017-08-01 09:21:51) > > > > -----Original Message----- > > > > From: Chris Wilson [mailto:[email protected]] > > > > Sent: Friday, July 28, 2017 2:30 PM > > > > To: Muthukumar, Aravindan <[email protected]>; mesa- > > > > [email protected] > > > > Cc: Marathe, Yogesh <[email protected]>; Muthukumar, > > > > Aravindan <[email protected]> > > > > Subject: Re: [Mesa-dev] [PATCH] i965: Avoids loop for buffer > > > > object availability in add_exec_bo > > > > > > > > Quoting [email protected] (2017-07-28 09:37:01) > > > > > From: Aravindan Muthukumar <[email protected]> > > > > > > > > > > Original logic loops over the list for every buffer object. > > > > > Maintained a flag to identify whether bo is already there in list. > > > > > > > > No. brw_bo is shared between many contexts, and so you are marking > > > > it as available in every one. May I suggest looking for issues in > > > > https://patchwork.freedesktop.org/series/27719/ and help bring > > > > that series to fruition. > > > > > > Thanks Chris, we'll get back. > > > > Agreed. The patch series you have pointed out covers it, patch can be > dropped. > > We tried applying series on master but it didn't apply cleanly, is > > there a base commit/branch on which this was tested / expected to work? > > The tip of https://cgit.freedesktop.org/~ickle/mesa/log/?h=qbo > i.e. > https://cgit.freedesktop.org/~ickle/mesa/commit/?h=qbo&id=b40fa6633bdac9 > 4cef2fd5f56360dfdb5eeb3738
I tested the patch series with mesa demos which seems functionally fine. Is there any specific functional/perf issue that needs to be looked at? > -Chris _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
