On 8 August 2017 at 10:21, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > > > On 08/08/2017 07:34 AM, Timothy Arceri wrote: >> >> On 01/08/17 19:37, Timothy Arceri wrote: >>> >>> On 01/08/17 18:07, Samuel Pitoiset wrote: >>>> >>>> Don't you think it's just safer to revert the bad commit for 17.2 and >>>> fix it later on? >>> >>> >>> I'm not overly worried. If you really want to go that way we can, but I >>> don't think it's necessary. >> >> >> So how do we move forward on this? Can we have the revert applied to 17.2 >> and commit this to master? > > > Sorry, missed that. I would prefer to revert yes, but opinions are welcome. > :-) > Thanks guys.
I think we're fine to have the revert for 17.2 and this series in master. When you send the revert please note that it's 17.2 only, and ideally reference the [comprehensive] fixes in master. Couple of suggestions: - the "+-" in the Makefile seems bogus, I think it should be "+" only? - s/When generation the/When generating the/ in the summary - reword the commit title to say what it does - "correctly calculate the storage offset" ? -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev