On Tue, 2017-08-08 at 12:12 -0700, Jordan Justen wrote: > On 2017-08-06 21:18:23, Iago Toral Quiroga wrote: > > The OpenGL 4.6 specs have been updated so that GetTextureParameter* > > with a texture object with an incompatible TEXTURE_TARGET should > > now > > report INVALID_OPERATION instead of INVALID_ENUM. > > > > Fixes: > > KHR-GL45.direct_state_access.textures_parameter_errors > > Assuming there is no regression with the GLES CTS, both patches: > > Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>
Thanks! Jenkins didn't report any regressions in GLES CTS, so I pushed them. Notice that this makes a couple of piglit tests that still expect the previous error codes fail, I have sent a patch to get these tests updated too: https://lists.freedesktop.org/archives/piglit/2017-August/022756.html Iago > > --- > > src/mesa/main/texparam.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c > > index b6e91503ea..039b93349e 100644 > > --- a/src/mesa/main/texparam.c > > +++ b/src/mesa/main/texparam.c > > @@ -174,7 +174,7 @@ get_texobj_by_name(struct gl_context *ctx, > > GLuint texture, const char *name) > > case GL_TEXTURE_RECTANGLE: > > return texObj; > > default: > > - _mesa_error(ctx, GL_INVALID_ENUM, "%s(target)", name); > > + _mesa_error(ctx, GL_INVALID_OPERATION, "%s(target)", name); > > return NULL; > > } > > > > -- > > 2.11.0 > > > > _______________________________________________ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev