Re: [Mesa-dev] [PATCH] intel/blorp: Adjust intra-tile x when faking rgb with red-only

[Pohjolainen, Topi]

On Sat, Aug 19, 2017 at 08:37:15AM -0700, Jason Ekstrand wrote:
> On August 19, 2017 7:24:55 AM Topi Pohjolainen <topi.pohjolai...@gmail.com>
> wrote:
> 
> >Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101910
> >
> >CC: Jason Ekstrand <ja...@jlekstrand.net>
> >CC: Mark Janes <mark.a.ja...@intel.com>
> >CC: mesa-sta...@lists.freedesktop.org
> >
> >Signed-off-by: Topi Pohjolainen <topi.pohjolai...@intel.com>
> >---
> > src/intel/blorp/blorp_blit.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> >diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c
> >index ed00516373..db93d0f585 100644
> >--- a/src/intel/blorp/blorp_blit.c
> >+++ b/src/intel/blorp/blorp_blit.c
> >@@ -1839,6 +1839,12 @@ try_blorp_blit(struct blorp_batch *batch,
> >       surf_get_intratile_offset_px(&params->dst,
> >                                    &params->wm_inputs.dst_offset.x,
> >                                    &params->wm_inputs.dst_offset.y);
> >+
> >+      if (wm_prog_key->dst_rgb) {
> >+         /* See surf_fake_rgb_with_red() */
> >+         params->wm_inputs.dst_offset.x *= 3;
> 
> It would be better to correct this in surf_fake_rgb_with_red by adjusting
> surf->tile_x_sa.

Specifically you mean "params->dst" here? I had a reason for not doing that
but can't remember what it was... Trying again as that would be a lot cleaner.

> 
> >+      }
> >+
> >       params->x0 += params->wm_inputs.dst_offset.x;
> >       params->y0 += params->wm_inputs.dst_offset.y;
> >       params->x1 += params->wm_inputs.dst_offset.x;
> >--
> >2.11.0
> >
> 
> 
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev