On Sat, 2017-08-19 at 21:40 +0100, Emil Velikov wrote:
> [Slimming down the CC list]
> 
> Hi Andres,
> 
> On 19 August 2017 at 16:37, Andres Gomez <[email protected]> wrote:
> 
> > 4c09f648929fbde25e4be44fa2983c0f3ac2fd11
> 
> commit 774e77ab64de05d437939110dd11c35a300d47f6
> Seems like the remaining shas are also off.
> 

Oh, damn! I messed up because of doing a rebase after listing here the
trivial merge conflicts ☹

> > Author: Emil Velikov <[email protected]>
> > 
> >     egl: avoid eglCreatePlatform*Surface{EXT,} crash with invalid dpy
> > 
> >     (cherry picked from commit 26fbb9eacddb1b809739cb12477bde13501d6d5a)
> > 
> 
> Conflict resolution looks good.
> 
> > Eric Engestrom (1):
> >       gbm: add gbm_bo_get_bpp()
> > 
> 
> This adds new API to libgbm. Something stable release should _not_ be doing.
> Although, yes, it is required for the egl/drm fixes below.
> 
> > Gwan-gyeong Mun (2):
> >       egl/drm: Fix misused x and y offsets in swrast_put_image2()
> >       egl/drm: Fix misused x and y offsets in swrast_get_image()
> > 
> 
> The issues exist since the code was introduced back in 2014.
> Hence I doubt there's a warrant to breaking existing assumptions and
> principles as mentioned above.
> 
> If the issue is quite severe we could keep the patches, although
> gbm_bo_get_bpp() should be internal.

You are right.

I think at this point is just better to drop those 3 patches.

-- 
Br,

Andres
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to