On 01/06/2012 05:36 PM, Eric Anholt wrote:
On Fri,  6 Jan 2012 15:34:47 -0700, Brian Paul<[email protected]>  wrote:
---
  src/mesa/main/fbobject.c |   12 ++++++++++++
  1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 912170a..aa35ba7 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -2742,6 +2742,18 @@ _mesa_BlitFramebufferEXT(GLint srcX0, GLint srcY0, GLint 
srcX1, GLint srcY1,
        }
     }

+   if (filter == GL_LINEAR&&  (mask&  GL_COLOR_BUFFER_BIT)) {
+      /* "Calling BlitFramebuffer will result in an INVALID_OPERATION error
+       * if filter is LINEAR and read buffer contains integer data."

I couldn't find this piece of text (though I would have hoped it
existed).  Care to cite which spec in the comment?

3.1 spec, 3rd paragraph of page 199. Or http://www.opengl.org/sdk/docs/man3/xhtml/glBlitFramebuffer.xml in the errors section.

It's not in the 3.0 spec, but I'm sure that was an oversight.

Same story for the buffer datatype check I posted in a later patch.

-Brian
_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to