On 13.09.2017 19:25, Emil Velikov wrote:
Hi Nicolai,

On 13 September 2017 at 18:04, Nicolai Hähnle <nhaeh...@gmail.com> wrote:
From: Nicolai Hähnle <nicolai.haeh...@amd.com>

---
  src/amd/common/ac_llvm_build.c                      | 5 ++++-
  src/amd/common/ac_llvm_build.h                      | 7 ++++++-
  src/amd/common/ac_nir_to_llvm.c                     | 4 ++--
  src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 2 +-
  4 files changed, 13 insertions(+), 5 deletions(-)

What's the difference between these three?

ac_llvm_context::chip_class

This one is newly introduced.

ac_nir_compiler_options::chip_class

This one is used to communicate the chip_class from radv to amd/common and will most likely stay.

ac_shader_abi::chip_class

This one is (among other things) used to communicate the chip_class from radv/radeonsi to the driver-independent parts of ac_nir_to_llvm, though we can phase it out in favor of ac_llvm_context::chip_class.

Cheers,
Nicolai


Is it be possible to remove the unneeded/duplicated ones?



-Emil



--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to