On 19/09/17 20:02, Jason Ekstrand wrote:


        +   if (image->shadow_surface.isl.size > 0 &&
        +       isl_format_is_compressed(view.format) &&
        +       (flags & ANV_IMAGE_VIEW_STATE_TEXTURE_OPTIMAL)) {
        +      assert(isl_format_is_compressed(surface->isl.format));
        +      assert(surface->isl.tiling == ISL_TILING_LINEAR);
        +      assert(image->shadow_surface.isl.tiling !=
        ISL_TILING_LINEAR);


    There is something odd here (I must misunderstand...).
    In make_surface() you always make the shadow_surface with linear
    tiling, yet here you're expecting it *not* to be linear?


No.  We set tiling to LINEAR and set needs_shadow.  When we actually create the shadow, we explicitly use TILING_ANY.

Thanks, I confused the shadow_surface was the tiled instead of the opposite.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to