On 21.09.2017 12:03, Eric Engestrom wrote:
Hmm, just noticed the title should be fixed. Something like this?
amd/addrlib: drop unnecessary va_copy()
Makes sense, but I already pushed it...
On Wednesday, 2017-09-20 14:48:46 +0000, Nicolai Hähnle wrote:
From: Nicolai Hähnle <[email protected]>
There's no reason to use va_copy here.
CID: 1418113
---
I have a slight preference for this variant.
--
src/amd/addrlib/core/addrobject.cpp | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/amd/addrlib/core/addrobject.cpp
b/src/amd/addrlib/core/addrobject.cpp
index dcdb1bffc2b..452feb5fac0 100644
--- a/src/amd/addrlib/core/addrobject.cpp
+++ b/src/amd/addrlib/core/addrobject.cpp
@@ -209,29 +209,25 @@ VOID Object::operator delete(
****************************************************************************************************
*/
VOID Object::DebugPrint(
const CHAR* pDebugString, ///< [in] Debug string
...
) const
{
#if DEBUG
if (m_client.callbacks.debugPrint != NULL)
{
- va_list ap;
-
- va_start(ap, pDebugString);
-
ADDR_DEBUGPRINT_INPUT debugPrintInput = {0};
debugPrintInput.size = sizeof(ADDR_DEBUGPRINT_INPUT);
debugPrintInput.pDebugString = const_cast<CHAR*>(pDebugString);
debugPrintInput.hClient = m_client.handle;
- va_copy(debugPrintInput.ap, ap);
+ va_start(debugPrintInput.ap, pDebugString);
m_client.callbacks.debugPrint(&debugPrintInput);
- va_end(ap);
+ va_end(debugPrintInput.ap);
}
#endif
}
} // Addr
--
2.11.0
--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
