On 10/01/2017 09:30 PM, Dave Airlie wrote:
On 1 Oct. 2017 22:03, "Bas Nieuwenhuizen" <[email protected] <mailto:[email protected]>> wrote:Why add this? It sounds like extra code for no reason?
According to the way we initialize DCC/CMASK/FMASK, I think we can end up by not allocating DCC and CMASK, and going to do useless decompression passes.
Also why add it after the meta saves?
This is wrong indeed.
Dave. On Fri, Sep 29, 2017 at 5:48 PM, Samuel Pitoiset <[email protected] <mailto:[email protected]>> wrote: > This should be a no-op. > > Signed-off-by: Samuel Pitoiset <[email protected] <mailto:[email protected]>> > --- > src/amd/vulkan/radv_meta_fast_clear.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/amd/vulkan/radv_meta_fast_clear.c b/src/amd/vulkan/radv_meta_fast_clear.c > index b92fb7cd5a..7e0738f44f 100644 > --- a/src/amd/vulkan/radv_meta_fast_clear.c > +++ b/src/amd/vulkan/radv_meta_fast_clear.c > @@ -365,6 +365,9 @@ radv_fast_clear_flush_image_inplace(struct radv_cmd_buffer *cmd_buffer, > radv_meta_save_pass(&saved_pass_state, cmd_buffer);> radv_meta_save_graphics_reset_vport_scissor_novertex(&saved_state,cmd_buffer); > > + if (!image->cmask.size && !image->fmask.size && !image->dcc_offset) > + return; > + > if (image->surface.dcc_size) {> radv_emit_set_predication_state_from_image(cmd_buffer, image, true);> cmd_buffer->state.predicating = true; > -- > 2.14.2 > > _______________________________________________ > mesa-dev mailing list > [email protected] <mailto:[email protected]> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev <https://lists.freedesktop.org/mailman/listinfo/mesa-dev> _______________________________________________ mesa-dev mailing list [email protected] <mailto:[email protected]> https://lists.freedesktop.org/mailman/listinfo/mesa-dev <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
