On 10/01/2017 07:11 AM, Bas Nieuwenhuizen wrote:
Do we know if this does not have any improvement for 128 bit MSAA,
even without fast clear?
Ah right, missed this point. I have no ideas though.
On Fri, Sep 29, 2017 at 5:48 PM, Samuel Pitoiset
<[email protected]> wrote:
Signed-off-by: Samuel Pitoiset <[email protected]>
---
src/amd/vulkan/radv_image.c | 3 ++-
src/amd/vulkan/radv_meta_clear.c | 5 -----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index c0578ff5d3..ce446f6569 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -864,7 +864,8 @@ radv_image_create(VkDevice _device,
if ((pCreateInfo->usage & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) &&
pCreateInfo->mipLevels == 1 &&
!image->surface.dcc_size && image->info.depth == 1 && can_cmask_dcc
&&
- !image->surface.is_linear)
+ !image->surface.is_linear &&
+ image->surface.bpe <= 8) /* 128 bit formats not supported */
radv_image_alloc_cmask(device, image);
if (image->info.samples > 1 &&
vk_format_is_color(pCreateInfo->format)) {
diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c
index 62c920e869..8f94242c5d 100644
--- a/src/amd/vulkan/radv_meta_clear.c
+++ b/src/amd/vulkan/radv_meta_clear.c
@@ -1038,11 +1038,6 @@ emit_fast_color_clear(struct radv_cmd_buffer *cmd_buffer,
radv_set_dcc_need_cmask_elim_pred(cmd_buffer, iview->image,
!can_avoid_fast_clear_elim);
} else {
-
- if (iview->image->surface.bpe > 8) {
- /* 128 bit formats not supported */
- return false;
- }
radv_fill_buffer(cmd_buffer, iview->image->bo,
iview->image->offset +
iview->image->cmask.offset,
iview->image->cmask.size, 0);
--
2.14.2
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
