On Tue, Oct 3, 2017 at 8:05 AM, Lionel Landwerlin
<lionel.g.landwer...@intel.com> wrote:
> We handle similar default valid for LOD in the fs backend for TXS/TXL.
> Without this we end up generating invalid MOV with a null src.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>
> Cc: "17.2 17.1" <mesa-sta...@lists.freedesktop.org>
> ---
> src/intel/compiler/brw_vec4_nir.cpp | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/intel/compiler/brw_vec4_nir.cpp
> b/src/intel/compiler/brw_vec4_nir.cpp
> index 0a1caa9fad8..9200ffa0ed7 100644
> --- a/src/intel/compiler/brw_vec4_nir.cpp
> +++ b/src/intel/compiler/brw_vec4_nir.cpp
> @@ -2228,6 +2228,15 @@ vec4_visitor::nir_emit_texture(nir_tex_instr *instr)
> }
> }
>
> + /* TXS and TXL require a LOD but not everything we implement using those
> + * two opcodes provides one. Provide a default LOD of 0.
> + */
> + if ((instr->op == nir_texop_txs ||
> + instr->op == nir_texop_txl) &&
> + lod.file == BAD_FILE) {
> + lod = brw_imm_ud(0u);
> + }
Reviewed-by: Matt Turner <matts...@gmail.com>
Really glad to see the EU validator catching bugs.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
