The spec requires the number of buffer to be greater than 0.

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>
---
 src/amd/vulkan/radv_cmd_buffer.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 366789decb..4eceb681ac 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2633,6 +2633,8 @@ void radv_CmdExecuteCommands(
 {
        RADV_FROM_HANDLE(radv_cmd_buffer, primary, commandBuffer);
 
+       assert(commandBufferCount > 0);
+
        /* Emit pending flushes on primary prior to executing secondary */
        si_emit_cache_flush(primary);
 
@@ -2688,12 +2690,12 @@ void radv_CmdExecuteCommands(
                primary->state.last_ia_multi_vgt_param = 
secondary->state.last_ia_multi_vgt_param;
        }
 
-       /* if we execute secondary we need to mark some stuff to reset dirty */
-       if (commandBufferCount) {
-               primary->state.dirty |= RADV_CMD_DIRTY_PIPELINE;
-               primary->state.dirty |= RADV_CMD_DIRTY_DYNAMIC_ALL;
-               radv_mark_descriptor_sets_dirty(primary);
-       }
+       /* After executing commands from secondary buffers we have to dirty
+        * some states.
+        */
+       primary->state.dirty |= RADV_CMD_DIRTY_PIPELINE;
+       primary->state.dirty |= RADV_CMD_DIRTY_DYNAMIC_ALL;
+       radv_mark_descriptor_sets_dirty(primary);
 }
 
 VkResult radv_CreateCommandPool(
-- 
2.14.2

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to