On Tue, Oct 10, 2017 at 4:43 AM, Eero Tamminen <[email protected]> wrote: > Hi, > > On 03.10.2017 08:20, Matt Turner wrote: >> >> A typo caused us to copy src0's reg file to src1 rather than reading >> src1's as intended. This caused us to fail to compact instructions like >> >> mov(8) g4<1>D 0D { align1 1Q }; >> >> because src1 was set to immediate rather than architecture file. Fixing >> this reenables compaction (after the precompact() pass changes the data >> types): >> >> mov(8) g4<1>UD 0x00000000UD { align1 1Q compacted }; >> >> Fixes: 1cb0a7941b27 ("i965: Switch to using the logical register types") > > > FYI: the original commit regressed SynMark v7 CSDof test performance by 1-2% > on GEN9+, and this fixes that performance regression.
Very interesting! Thanks. _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
