Emil Velikov <emil.l.veli...@gmail.com> writes:
> Hi Vedran,
>
> Just pushed the LLVM version bump, so this patch should be able to go in.
> I won't be able to offer any review here, apart from a small suggestion.
>
> On 9 October 2017 at 00:08, Vedran Miletić <ved...@miletic.net> wrote:
>
>> #include <clang/Basic/TargetInfo.h>
>> #include <clang/Frontend/CodeGenOptions.h>
>> @@ -63,11 +56,7 @@
>> namespace clover {
>> namespace llvm {
>> namespace compat {
>> -#if HAVE_LLVM >= 0x0307
>> typedef ::llvm::TargetLibraryInfoImpl target_library_info;
>> -#else
>> - typedef ::llvm::TargetLibraryInfo target_library_info;
>> -#endif
>>
> With the guards gone, one should be able to remove/inline compat stuff
> like this.
> Not sure how much it matters or if one isn't going to need anyway for
> newer LLVM.
>Agree with Emil, a few of these compatibility defininitions now become trivial and could be folded into their uses. Still seems like a good start, patch is: Reviewed-by: Francisco Jerez <curroje...@riseup.net> > -Emil
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
