-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 16.01.2012 19:05, Jose Fonseca wrote: >> Why not just move the definition of frame_pointer into the >> #ifdef PIPE_ARCH_X86 ? > > It would be cleaner, but it would require C99 as the declaration > would appear after code, which would break MSVC. I think it's > better to commit Vinson's patch as is.
Ok. Still, the builtin in the second #ifdef is useless as the variable will never be used. However, this is another issue I guess. Best regards Tolga Dalman -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPFTTQAAoJEI0vwg8AaIlUExgH/381BglTKg5vpIBtSx/Fargl ZyL7lPbHh6bv5D3aVACvP3zDORVRjOktcZtTmrzD/ZkyoXl5mRoWd4ET9lQ1eu2T 9s0cqkrPPeVh7f/7SjO7P6GPAtCuGtmOIxw1WHPFrakrZrHpTjXykNgsogObcOJ1 iG7gseS1V0xQ5JL6n6TzExcR4G1pfbkjrnsI80OCrQFBoWEAL4R6ag+Pp2e0roKs buchtdwaMg/z91gHbAxiAfC6aIPo+9azocq//SpIbisX6FPDCdv7AlrJJAn/fYwB RC60sYJRPic8OZJ9h9UOuQANZUyp6oz08fM9o/+HOW5aGmNWHBLhKkUb3RgFGN4= =A7/a -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev