On Tue, Oct 31, 2017 at 12:54 AM, Kenneth Graunke <[email protected]> wrote: > On Sunday, October 22, 2017 1:01:40 PM PDT Jordan Justen wrote: >> This would cause the read of the metadata content to fail, which would >> prevent the linking from being skipped. >> >> Seen on Rocket League with i965 shader cache. >> >> Cc: Timothy Arceri <[email protected]> >> Signed-off-by: Jordan Justen <[email protected]> >> Reviewed-by: Timothy Arceri <[email protected]> >> --- >> src/util/disk_cache.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c >> index e38cacb259b..fde6e2e0974 100644 >> --- a/src/util/disk_cache.c >> +++ b/src/util/disk_cache.c >> @@ -1110,7 +1110,7 @@ disk_cache_get(struct disk_cache *cache, const >> cache_key key, size_t *size) >> * TODO: pass the metadata back to the caller and do some basic >> * validation. >> */ >> - cache_item_md_size += sizeof(cache_key); >> + cache_item_md_size += num_keys * sizeof(cache_key); >> ret = lseek(fd, num_keys * sizeof(cache_key), SEEK_CUR); >> if (ret == -1) >> goto fail; >> > > Reviewed-by: Kenneth Graunke <[email protected]>
Fixes: b86ecea3446e "util/disk_cache: write cache item metadata to disk" _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
