On Tuesday, 2017-10-31 19:26:32 +0000, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > Currently we were overwriting the existing warning flags, instead of > adding new [as applicable]. > > Fixes e4b2b69e828 ("configure: Add and use AX_CHECK_COMPILE_FLAG") > Cc: Matt Turner <matts...@gmail.com> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > configure.ac | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/configure.ac b/configure.ac > index efc653ad7fa..1bba6c5b208 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -309,11 +309,11 @@ AC_LANG_POP([C++]) > # - non-Linux/Posix OpenGL portions needs to build on MSVC 2013 (which > # supports most of C99) > # - the rest has no compiler compiler restrictions > -AX_CHECK_COMPILE_FLAG([-Werror=pointer-arith], > [MSVC2013_COMPAT_CFLAGS="-Werror=pointer-arith"]) > -AX_CHECK_COMPILE_FLAG([-Werror=vla], > [MSVC2013_COMPAT_CFLAGS="-Werror=vla"]) > +AX_CHECK_COMPILE_FLAG([-Werror=pointer-arith], > [MSVC2013_COMPAT_CFLAGS="$MSVC2013_COMPAT_CFLAGS-Werror=pointer-arith"])
Missing space between `$MSVC2013_COMPAT_CFLAGS` and `-Werror` With that fixed, both patches are Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > +AX_CHECK_COMPILE_FLAG([-Werror=vla], > [MSVC2013_COMPAT_CFLAGS="$MSVC2013_COMPAT_CFLAGS -Werror=vla"]) > AC_LANG_PUSH([C++]) > -AX_CHECK_COMPILE_FLAG([-Werror=pointer-arith], > [MSVC2013_COMPAT_CXXFLAGS="-Werror=pointer-arith"]) > -AX_CHECK_COMPILE_FLAG([-Werror=vla], > [MSVC2013_COMPAT_CXXFLAGS="-Werror=vla"]) > +AX_CHECK_COMPILE_FLAG([-Werror=pointer-arith], > [MSVC2013_COMPAT_CXXFLAGS="$MSVC2013_COMPAT_CXXFLAGS -Werror=pointer-arith"]) > +AX_CHECK_COMPILE_FLAG([-Werror=vla], > [MSVC2013_COMPAT_CXXFLAGS="$MSVC2013_COMPAT_CXXFLAGS -Werror=vla"]) > AC_LANG_POP([C++]) > > AC_SUBST([MSVC2013_COMPAT_CFLAGS]) > -- > 2.14.1 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev