On Wed, Nov 1, 2017 at 3:32 PM, Wladimir J. van der Laan <laa...@gmail.com> wrote: > >> These formats are in a completely different space from the others, in the >> hardware (programmed through a different register), so IMO it makes sense to >> add a new format bit for it, just like for EXT_FORMAT. >> >> Relying on mesa's judgement on whether something is astc seems brittle. >> >> >> Sorry I do not share this option. Did you had a look at >> https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/auxiliary/util/u_ >> format.csv ? >> >> All astc formats are marked as those and why should we not trust mesa here? > > Well vivante's opinion of what an ASTC format might differ from mesa's > some day. I think we should keep specific implementation details
These aren't supported today in gallium (due to no hw support), but be aware that there are 3D ASTC formats, which would likely be considered to be "astc" by an updated util_format_is_astc(). Most drivers have an explicit list of formats they support though, so if it's just for code that processes already-validated formats, it shouldn't be a problem to use util_format_is_astc() since you know that it must be a format that is in the table already. -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
