Re: [Mesa-dev] [RFC PATCH v1 12/30] anv: Rename get_image_format_properties()

[Lionel Landwerlin]

Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com>

On 07/11/17 14:47, Chad Versace wrote:

The name is misleading. It looks like 
vkGetPhysicalDeviceImageFormatProperties(),
but it actually implement vkGetPhysicalDeviceFormatProperties. Let's
rename it to what it actually does, get_image_format_features(), because it
returns VkFormatFeatureFlags.

For consistency, also rename get_buffer_format_properties() to
get_buffer_format_features().
---
  src/intel/vulkan/anv_formats.c | 24 ++++++++++++------------
  1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 3c946308895..bd34e1ffabb 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
@@ -467,10 +467,10 @@ anv_get_format_plane(const struct gen_device_info 
*devinfo, VkFormat vk_format,
  // Format capabilities

static VkFormatFeatureFlags

-get_image_format_properties(const struct gen_device_info *devinfo,
-                            VkFormat vk_format,
-                            const struct anv_format *anv_format,
-                            VkImageTiling vk_tiling)
+get_image_format_features(const struct gen_device_info *devinfo,
+                          VkFormat vk_format,
+                          const struct anv_format *anv_format,
+                          VkImageTiling vk_tiling)
  {
     VkFormatFeatureFlags flags = 0;

@@ -612,9 +612,9 @@ get_image_format_properties(const struct gen_device_info *devinfo,

  }

static VkFormatFeatureFlags

-get_buffer_format_properties(const struct gen_device_info *devinfo,
-                             VkFormat vk_format,
-                             const struct anv_format *anv_format)
+get_buffer_format_features(const struct gen_device_info *devinfo,
+                           VkFormat vk_format,
+                           const struct anv_format *anv_format)
  {
     VkFormatFeatureFlags flags = 0;

@@ -663,16 +663,16 @@ anv_physical_device_get_format_properties(struct anv_physical_device *physical_d

     if (format == NULL) {
        /* Nothing to do here */
     } else {
-      linear = get_image_format_properties(&physical_device->info, vk_format,
-                                           format, VK_IMAGE_TILING_LINEAR);
-      tiled = get_image_format_properties(&physical_device->info, vk_format,
-                                          format, VK_IMAGE_TILING_OPTIMAL);
+      linear = get_image_format_features(&physical_device->info, vk_format,
+                                         format, VK_IMAGE_TILING_LINEAR);
+      tiled = get_image_format_features(&physical_device->info, vk_format,
+                                        format, VK_IMAGE_TILING_OPTIMAL);
     }

out_properties->linearTilingFeatures = linear;

     out_properties->optimalTilingFeatures = tiled;
     out_properties->bufferFeatures =
-     get_buffer_format_properties(devinfo, vk_format, format);
+      get_buffer_format_features(devinfo, vk_format, format);
  }

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev