Looks good to me.
Reviewed-by: Neha Bhende <bhen...@vmware.com> Regards, Neha ________________________________ From: mesa-dev <mesa-dev-boun...@lists.freedesktop.org> on behalf of Brian Paul <bri...@vmware.com> Sent: Friday, November 10, 2017 6:40:26 PM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] svga: issue debug warning for unsupported two-sided stencil state We only have a single stencil read mask and write mask. Issue a warning if different front/back values are used. The Piglit gl-2.0-two-sided-stencil test hits this. --- src/gallium/drivers/svga/svga_pipe_depthstencil.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/svga/svga_pipe_depthstencil.c b/src/gallium/drivers/svga/svga_pipe_depthstencil.c index 1b62290..e5caa4b 100644 --- a/src/gallium/drivers/svga/svga_pipe_depthstencil.c +++ b/src/gallium/drivers/svga/svga_pipe_depthstencil.c @@ -172,6 +172,21 @@ svga_create_depth_stencil_state(struct pipe_context *pipe, ds->stencil_mask = templ->stencil[1].valuemask & 0xff; ds->stencil_writemask = templ->stencil[1].writemask & 0xff; + + if (templ->stencil[1].valuemask != templ->stencil[0].valuemask) { + pipe_debug_message(&svga->debug.callback, CONFORMANCE, + "two-sided stencil mask not supported " + "(front=0x%x, back=0x%x)", + templ->stencil[0].valuemask, + templ->stencil[1].valuemask); + } + if (templ->stencil[1].writemask != templ->stencil[0].writemask) { + pipe_debug_message(&svga->debug.callback, CONFORMANCE, + "two-sided stencil writemask not supported " + "(front=0x%x, back=0x%x)", + templ->stencil[0].writemask, + templ->stencil[1].writemask); + } } else { /* back face state is same as front-face state */ -- 1.9.1 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=U9C05uEFArICiTQ6FqFIgVCB-YGE5G2JTThVEccv_Ec&m=G0jOYq_LoVonAPIAMBNujnLcGheNLWedG3WtYO3mbn0&s=QluX83Fb70cz1E8pS8V7mR4zpiIvPP-mO6XYaN-D7bU&e=
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev