Am 29.11.2017 um 05:02 schrieb Gurkirpal Singh:
These are the refactored commits related to the GSoC project involving adding a st/omx state tracker using tizonia. There are still some parts of code that i didn't refactor yet as explained below: 1) I wasn't sure if it's okay to use #if-#else declaratives for function declarations. For eg: One function accepts omx_base_PortType and the other one vid_dec_PrivateType 2) Because of the argument type differences there is excessive amounts of #if-#else pairs will be needed So I decided to wait for review before making those changes.
Looks really good to me and I think as well that we should avoid excessive #if-#else pairs even if that means we have a bit of code duplication.
One question I have is why do you move the vl screen helpers into the auxiliary code in the first patch and not just keep it as common code under the st/omx directory?
I mean could make sense to use that somewhere else, but we currently don't do this and your solution for the rest of the code looks, e.g. the H264 decoder, looks really nice to me.
And the EGL image stuff really works? Well that is extremely cool. Regards, Christian.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
