Yeah, this also matches the comments above which explain what it's doing... src[0] == LO, src[1] == HI.
Reviewed-by: Ilia Mirkin <imir...@alum.mit.edu> On Sun, Dec 3, 2017 at 3:28 PM, Pierre Moreau <pierre.mor...@free.fr> wrote: > Fixes: 61d7676df77 "nvc0/ir: add support for 64-bit shift lowering on > SM20/SM30" > > Fixes fs-shift-scalar-by-scalar.shader_test from piglit for the current > set-up: > > uniform int64_t ival -0x7dfcfefbdf6536ff # bit pattern: 0x82030104209ac901 > uniform uint64_t uval 0x1400000085010203 > uniform int shl 36 > uniform int shr 36 > uniform int64_t iexpected_shl 0x09ac901000000000 > uniform int64_t iexpected_shr -0x7dfcff0 # bit pattern: 0xfffffffff8203010 > uniform uint64_t uexpected_shl 0x5010203000000000 > uniform uint64_t uexpected_shr 0x0000000001400000 > draw rect ortho 12 0 4 4 > > Signed-off-by: Pierre Moreau <pierre.mor...@free.fr> > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp > b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp > index 7243b1d2e4..6b51b7607c 100644 > --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp > +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp > @@ -216,7 +216,7 @@ NVC0LegalizeSSA::handleShift(Instruction *lo) > // Compute LO (all shift values) > bld.mkOp2(op, type, (dst[0] = bld.getSSA()), src[0], shift); > // Compute HI (shift > 32) > - bld.mkOp2(op, type, (hi2 = bld.getSSA()), src[1], > + bld.mkOp2(op, type, (hi2 = bld.getSSA()), src[0], > bld.mkOp1v(OP_NEG, TYPE_S32, bld.getSSA(), x32_minus_shift)) > ->setPredicate(CC_NOT_P, pred); > bld.mkOp2(OP_UNION, TYPE_U32, (dst[1] = bld.getSSA()), hi1, hi2); > -- > 2.15.0 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
