In Vulkan, we don't support classic pull constants and everything the client asks us to push, we push. However, for pushed UBOs, we still want to fall back to conventional pulls if we run out of space. --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp index ffd8e12..fbbb2a1 100644 --- a/src/intel/compiler/brw_fs.cpp +++ b/src/intel/compiler/brw_fs.cpp @@ -2112,7 +2112,7 @@ fs_visitor::assign_constant_locations() unsigned push_start_align = cplx_align_apply(align, num_push_constants); unsigned chunk_size = u - chunk_start + 1; - if (!compiler->supports_pull_constants || + if ((!compiler->supports_pull_constants && u < UBO_START) || (chunk_size < max_chunk_size && push_start_align + chunk_size <= max_push_components)) { /* Align up the number of push constants */ -- 2.5.0.400.gff86faf _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev