Reviewed-by: Jason Ekstrand <[email protected]>
On Mon, Dec 4, 2017 at 6:21 PM, Rob Herring <[email protected]> wrote:
> Commit 94ca8e04adf6 ("spirv: Add vtn_fail and vtn_assert helpers") broke
> Android builds which have -Werror enabled with the following errors:
>
> external/mesa3d/src/compiler/spirv/spirv_to_nir.c:272:1: error: control
> may reach end of non-void function [-Werror,-Wreturn-type]
> external/mesa3d/src/compiler/spirv/spirv_to_nir.c:810:1: error: control
> may reach end of non-void function [-Werror,-Wreturn-type]
> ...
>
> The problem is the noreturn attribute is not enabled and we to define
> HAVE_FUNC_ATTRIBUTE_NORETURN.
>
> Auditing src/util/macros.h, we're also missing
> HAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL, so add it too.
>
> Fixes: 94ca8e04adf6 ("spirv: Add vtn_fail and vtn_assert helpers")
> Cc: Jason Ekstrand <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> Android.common.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Android.common.mk b/Android.common.mk
> index f080d996a7d9..f905c5e697d0 100644
> --- a/Android.common.mk
> +++ b/Android.common.mk
> @@ -57,6 +57,8 @@ LOCAL_CFLAGS += \
> -DHAVE_FUNC_ATTRIBUTE_FORMAT \
> -DHAVE_FUNC_ATTRIBUTE_PACKED \
> -DHAVE_FUNC_ATTRIBUTE_ALIAS \
> + -DHAVE_FUNC_ATTRIBUTE_NORETURN \
> + -DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL \
> -DHAVE___BUILTIN_CTZ \
> -DHAVE___BUILTIN_POPCOUNT \
> -DHAVE___BUILTIN_POPCOUNTLL \
> --
> 2.14.1
>
> _______________________________________________
> mesa-dev mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
