On Wed, Dec 13, 2017 at 10:45 PM, Mario Kleiner <mario.kleiner...@gmail.com> wrote: > On 12/13/2017 05:27 PM, Marek Olšák wrote: >> >> Mario, can we push these patches? >> >> Marek >> > > Sorry for the late response and thanks for the reviews! Was a bit sick the > last days, so couldn't think or do anything about the recent comments so > far. > > I think all patches have a r-b by you and/or Tapani, except the nouveau > patch 20/22 on which Ilia commented. Not sure about that one. If we leave it > out then stuff breaks on nouveau. If we leave it in, then as far as i > understand Ilia's comments, we have a slight violation of spec atm. - If a > app asks for a framebuffer without alpha channel (xrgb2101010), but then > enables blending with DST_ALPHA it would potentially get random 2 x-bit > trash instead of a well defined 1.0 DST_ALPHA. Otoh. it would be legal but a > bit non-sensical for an app to ask for no alpha channel, but then choose > blend functions that only make sense with an alpha channel? > > The third option would be to replace that patch with one that disables the > rgb10 support for visuals on nouveau completely until we have a solution for > properly emulating xrgb201010 on nouveau to cover such corner cases?
Hold on ... my understanding was that without that patch, nouveau just wouldn't work with 30-bit. Which is the current status quo. I'd like to investigate first-hand what the breakage is, perhaps it's actually unrelated to the missing format, and can be made to work just fine with the st using argb2101010. Am I misunderstanding the state of things? I really don't want nouveau to be holding anything up. -ilia _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
