On Thu, Jan 4, 2018 at 8:16 AM, Eric Engestrom
<eric.engest...@imgtec.com> wrote:
> On Wednesday, 2018-01-03 10:28:37 -0600, Rob Herring wrote:
>> Commit 2f421651aca9 ("egl: let each platform decided how to handle
>> LIBGL_ALWAYS_SOFTWARE") broke the build due to copy-n-paste of misnamed
>> function parameter.:
>>
>> src/egl/drivers/dri2/platform_android.c:1183:8: error: use of undeclared
>> identifier 'disp'
>>
>> Rather than just fixing 'disp', rename the function parameter 'dpy' to
>> 'disp' to align with the other EGL platforms' implementations.
>>
>> Fixes: 2f421651aca9 ("egl: let each platform decided how to handle
>> LIBGL_ALWAYS_SOFTWARE")
>> Cc: Eric Engestrom <eric.engest...@imgtec.com>
>> Signed-off-by: Rob Herring <r...@kernel.org>
>
> Apologies, I didn't think to check this, and I don't have a setup to
> build Mesa on Android so it didn't even get build-tested :(
You just have to push a branch[1].
> Fwiw Mauro also emailed me last week about this, but I only just got
> back from holiday this morning.
>
> Renaming to align with other platforms sounds like the right fix:
> Acked-by: Eric Engestrom <eric.engest...@imgtec.com>
Thanks.
Rob
[1] https://lists.freedesktop.org/archives/mesa-dev/2017-October/172604.html
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
