https://bugs.freedesktop.org/show_bug.cgi?id=45420
--- Comment #5 from José Fonseca <jfons...@vmware.com> 2012-02-01 03:45:04 PST
---
(In reply to comment #4)
> Created attachment 56422 [details] [review]
> Proposed fix for LLVM-2.7
>
> I don't really know how to properly fix this for all targets, because
> LLVM_NATIVE_ARCH in LLVM-2.7 is ${LLVM_NATIVE_ARCH}Target (X86Target for X86,
> ARMTarget for ARM etc), so it's not possible to write something like
> #define LLVM_ASM_PRINTER(TargetName) LLVMInitialize##TargetName##AsmPrinter();
> to fix all targets. Attached patch adds defines only for for X86 and ARM, is
> it
> sufficient, should it be added for other targets or it can be completely
> skipped for LLVM < 2.8?
> Patch also adds needed defines for LLVM Disassembler.
Thanks ojab.
> Also llvmpipe docs say that "LLVM: version 2.9 recommended; 2.6 or later
> required", is it up-to-date and build should also be tested with LLVM-2.6?
The ability to build with LLVM-2.6 is still useful for now, as it is one of the
most stable LLVM releases for us ever.
But the ability to disassemble w/ LLVM 2.7 or eralier is not really important
(as most developers will have recent LLVM anyway), so we could simply cut our
losses and do:
--- a/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
+++ b/src/gallium/auxiliary/gallivm/lp_bld_debug.cpp
@@ -172,7 +172,7 @@ public:
extern "C" void
lp_disassemble(const void* func)
{
-#if HAVE_LLVM >= 0x0207
+#if HAVE_LLVM >= 0x0208
using namespace llvm;
const uint8_t *bytes = (const uint8_t *)func;
Vinson, I don't have LLVM 2.7. Could you verify either ojab's or my change
fixes the build issue?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
