On 01/24/2018 05:22 AM, Dave Airlie wrote:
From: Dave Airlie <[email protected]>

This seems to be broken, at least the cts tests fail.

This fixes:
dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_4
dEQP-VK.renderpass.suballocation.multisample.d32_sfloat_s8_uint.samples_8

2 samples seems to pass fine, amdvlk doesn't appear to enable TC for
possibly some other reasons here.

This is most likely a hack.

Signed-off-by: Dave Airlie <[email protected]>
---
  src/amd/vulkan/radv_image.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index 54b2b52..66249e5 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -116,7 +116,7 @@ radv_init_surface(struct radv_device *device,
                    pCreateInfo->mipLevels <= 1 &&
                    device->physical_device->rad_info.chip_class >= VI &&
                    ((pCreateInfo->format == VK_FORMAT_D32_SFLOAT ||
-                     pCreateInfo->format == VK_FORMAT_D32_SFLOAT_S8_UINT) ||
+                     (pCreateInfo->samples < 4 && pCreateInfo->format == 
VK_FORMAT_D32_SFLOAT_S8_UINT)) ||

Mmh yeah, I think we should at least explain why (and/or add a TODO).

                     (device->physical_device->rad_info.chip_class >= GFX9 &&
                      pCreateInfo->format == VK_FORMAT_D16_UNORM)))
                        surface->flags |= RADEON_SURF_TC_COMPATIBLE_HTILE;

_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to