On 24 November 2017 at 18:26, Eric Engestrom <eric.engest...@imgtec.com> wrote:
> On Friday, 2017-11-24 18:14:41 +0000, Emil Velikov wrote:
>> On 24 November 2017 at 14:32, Eric Engestrom <eric.engest...@imgtec.com>
>> wrote:
>> > On Friday, 2017-11-24 14:25:02 +0000, Emil Velikov wrote:
>> >> From: Emil Velikov <emil.veli...@collabora.com>
>> >>
>> >> From the manual:
>> >> Warn if an undefined identifier is evaluated in an `#if' directive.
>> >>
>> >> This is something we want to know and address. Otherwise we can end up
>> >> with subtle issues, in the less commonly used codepaths.
>> >>
>> >> Note: this will trigger a lot of extra warnings, with ~60 of those being
>> >> unique. Once all those are resolved we'd want to promote the warning to
>> >> an error.
>> >
>> > Yes please; series is
>> > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com>
>> >
>> Thanks. I think we should hold these off, until some (say 1/3?) of the
>> issues are resolved.
>> Otherwise devs might get a bit annoyed my the massive amount of warnings.
>
> Agreed. The series I just sent fixes 99% of the warnings already,
> because c99_{compat,math}.h is included everywhere.
>
> Once that series and your gtest patches land, if think it should be good
> enough, and individual devs can take care of the rest.
>
> The next biggest offender is Nouveau, and I haven't had a proper look
> but at a glance I think it looked like it was probably just a few places
> generating many warnings.
FTR, I haven't forgotten about this one. Upstream gtest has not
replied to the series that I've posted nearly 2 months ago [1].
I'd love to address any feedback and flow things naturally into Mesa.
Alternatively we could pull it locally, although next time we update
gtest things might be fiddly.
-Emil
[1] https://github.com/google/googletest/pull/1335
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
