Yep, tested on our side, and looks good. Reviewed-By: George Kyriazis <george.kyria...@intel.com<mailto:george.kyria...@intel.com>>
On Jan 29, 2018, at 9:42 AM, Chuck Atkins <chuck.atk...@kitware.com<mailto:chuck.atk...@kitware.com>> wrote: Lgtm, should probably get a rb from Intel though to make sure it doesn't break anything they're trying to do. Tested-by: Chuck Atkins <chuck.atk...@kitware.com<mailto:chuck.atk...@kitware.com>> On Jan 29, 2018 07:09, "Emil Velikov" <emil.l.veli...@gmail.com<mailto:emil.l.veli...@gmail.com>> wrote: On 22 January 2018 at 17:52, Emil Velikov <emil.l.veli...@gmail.com<mailto:emil.l.veli...@gmail.com>> wrote: > From: Emil Velikov > <emil.veli...@collabora.com<mailto:emil.veli...@collabora.com>> > > With earlier rework the user and provider of the symbol are within the > same binary. Thus there's no point in exporting the function. > > Spotted while reviewing patch from Chuck, that nearly added another > unneeded PUBLIC function. > > Cc: Chuck Atkins <chuck.atk...@kitware.com<mailto:chuck.atk...@kitware.com>> > Cc: Tim Rowley <timothy.o.row...@intel.com<mailto:timothy.o.row...@intel.com>> > Fixes: f50aa21456d "(swr: build driver proper separate from rasterizer") > Signed-off-by: Emil Velikov > <emil.veli...@collabora.com<mailto:emil.veli...@collabora.com>> > --- > The comment might need updating as well, although I'm short on > suggestions. > --- > src/gallium/drivers/swr/swr_public.h | 2 +- > src/gallium/drivers/swr/swr_screen.cpp | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/swr/swr_public.h > b/src/gallium/drivers/swr/swr_public.h > index 4b150705cd7..cb205479a91 100644 > --- a/src/gallium/drivers/swr/swr_public.h > +++ b/src/gallium/drivers/swr/swr_public.h > @@ -36,7 +36,7 @@ extern "C" { > struct pipe_screen *swr_create_screen(struct sw_winsys *winsys); > > // arch-specific dll entry point > -PUBLIC struct pipe_screen *swr_create_screen_internal(struct sw_winsys > *winsys); > +struct pipe_screen *swr_create_screen_internal(struct sw_winsys *winsys); > > #ifdef _WIN32 > void swr_gdi_swap(struct pipe_screen *screen, > diff --git a/src/gallium/drivers/swr/swr_screen.cpp > b/src/gallium/drivers/swr/swr_screen.cpp > index b67ac25ac89..10b7e891aca 100644 > --- a/src/gallium/drivers/swr/swr_screen.cpp > +++ b/src/gallium/drivers/swr/swr_screen.cpp > @@ -1114,7 +1114,6 @@ swr_validate_env_options(struct swr_screen *screen) > } > > > -PUBLIC > struct pipe_screen * > swr_create_screen_internal(struct sw_winsys *winsys) > { > -- Humble ping? -Eiml
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
