Reviewed-by: Tapani Pälli <tapani.pa...@intel.com>

(I verified the 1st one and I trust you on the 2nd one.)

BTW I witnessed pahole crashing when processing visit() methods of ir_print_visitor class, did you experience that? My pahole version is 1.9, it dies in /lib64/libdwarves.so.1 after some prints like:

--- 8< ---
die__process_unit: DW_TAG_restrict_type (0x37) @ <0x122be84> not handled!
die__process_unit: DW_TAG_unspecified_type (0x3b) @ <0x1230c68> not handled!
die__process_unit: DW_TAG_restrict_type (0x37) @ <0x12312d3> not handled!
die__process_unit: DW_TAG_unspecified_type (0x3b) @ <0x1231bc4> not handled!
die__process_unit: DW_TAG_restrict_type (0x37) @ <0x12340bb> not handled!
die__process_unit: DW_TAG_rvalue_reference_type (0x42) @ <0x123f984> not handled! die__process_unit: DW_TAG_rvalue_reference_type (0x42) @ <0x1242348> not handled! die__process_unit: DW_TAG_rvalue_reference_type (0x42) @ <0x1242398> not handled! die__process_unit: DW_TAG_rvalue_reference_type (0x42) @ <0x12423e8> not handled! die__process_unit: DW_TAG_rvalue_reference_type (0x42) @ <0x1242572> not handled! die__process_unit: DW_TAG_rvalue_reference_type (0x42) @ <0x12425c2> not handled! die__process_unit: DW_TAG_rvalue_reference_type (0x42) @ <0x12425ea> not handled! die__process_function: DW_TAG_rvalue_reference_type (0x42) @ <0x1247929> not handled!



On 31.01.2018 01:41, Dave Airlie wrote:
This month's Dave hasn't got enough sleep to do real work, lets
repack some structs.

The format descriptions one is quite good though it reduces the
radv binary data segment.

Dave.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to