On Friday, January 26, 2018 5:59:31 PM PST Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c > b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c > index 611e850..39985f0 100644 > --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c > +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c > @@ -559,6 +559,12 @@ static void brw_update_texture_surface(struct gl_context > *ctx, > .usage = ISL_SURF_USAGE_TEXTURE_BIT, > }; > > + /* On Ivy Bridge and earlier, we handle texture swizzle with shader > + * code. The actual surface swizzle should be identity. > + */ > + if (brw->gen <= 7 && !brw->is_haswell)
Needs to be devinfo, not brw. You fixed this but accidentally squashed it into the next patch instead of this one. > + view.swizzle = ISL_SWIZZLE_IDENTITY; > + > if (obj->Target == GL_TEXTURE_CUBE_MAP || > obj->Target == GL_TEXTURE_CUBE_MAP_ARRAY) > view.usage |= ISL_SURF_USAGE_CUBE_BIT; > Patches 2-4 are: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
