For patch 2 and 3, Reviewed-by: Charmaine Lee <charmai...@vmware.com>
________________________________________ From: Brian Paul <bri...@vmware.com> Sent: Wednesday, February 14, 2018 1:15:14 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 3/3] svga: move duplicated code for setting fillmode/flatshade state Move the calls to svga_hwtnl_set_fillmode() and svga_hwtnl_set_flatshade() out of the two retry_draw_*() functions to the svga_draw_vbo() function. --- src/gallium/drivers/svga/svga_pipe_draw.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/src/gallium/drivers/svga/svga_pipe_draw.c b/src/gallium/drivers/svga/svga_pipe_draw.c index af53881..c73c406 100644 --- a/src/gallium/drivers/svga/svga_pipe_draw.c +++ b/src/gallium/drivers/svga/svga_pipe_draw.c @@ -64,16 +64,6 @@ retry_draw_range_elements(struct svga_context *svga, SVGA_STATS_TIME_PUSH(svga_sws(svga), SVGA_STATS_TIME_DRAWELEMENTS); - svga_hwtnl_set_fillmode(svga->hwtnl, svga->curr.rast->hw_fillmode); - - /** determine if flatshade is to be used after svga_update_state() - * in case the fragment shader is changed. - */ - svga_hwtnl_set_flatshade(svga->hwtnl, - svga->curr.rast->templ.flatshade || - is_using_flat_shading(svga), - svga->curr.rast->templ.flatshade_first); - for (unsigned try = 0; try < 2; try++) { ret = svga_hwtnl_draw_range_elements(svga->hwtnl, index_buffer, index_size, @@ -100,16 +90,6 @@ retry_draw_arrays(struct svga_context *svga, SVGA_STATS_TIME_PUSH(svga_sws(svga), SVGA_STATS_TIME_DRAWARRAYS); - svga_hwtnl_set_fillmode(svga->hwtnl, svga->curr.rast->hw_fillmode); - - /** determine if flatshade is to be used after svga_update_state() - * in case the fragment shader is changed. - */ - svga_hwtnl_set_flatshade(svga->hwtnl, - svga->curr.rast->templ.flatshade || - is_using_flat_shading(svga), - svga->curr.rast->templ.flatshade_first); - for (unsigned try = 0; try < 2; try++) { ret = svga_hwtnl_draw_arrays(svga->hwtnl, prim, start, count, start_instance, instance_count); @@ -230,6 +210,16 @@ svga_draw_vbo(struct pipe_context *pipe, const struct pipe_draw_info *info) assert(ret == PIPE_OK); } + svga_hwtnl_set_fillmode(svga->hwtnl, svga->curr.rast->hw_fillmode); + + /** determine if flatshade is to be used after svga_update_state() + * in case the fragment shader is changed. + */ + svga_hwtnl_set_flatshade(svga->hwtnl, + svga->curr.rast->templ.flatshade || + is_using_flat_shading(svga), + svga->curr.rast->templ.flatshade_first); + if (info->index_size && indexbuf) { unsigned offset; -- 2.7.4 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev