On 17 February 2018 at 15:04, Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
> (-mesa-announce + Mark, Dave and James)
> Hi Emil,
> radv is broken for nearly all commercial games in 17.3.4. The cause is
> commit ad764e365beb8a119369b97f22225cb95fc7ea8c
> Author: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
> Date: Mon Jan 22 09:01:29 2018 +0100
> ac/nir: Use instance_rate_inputs per attribute, not per variable.
> This did the wrong thing if we had e.g. an array for which only some
> of the attributes use the instance index. Tripped up some new CTS
> CC: <mesa-sta...@lists.freedesktop.org>
> Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com>
> Reviewed-by: Dave Airlie <airl...@redhat.com>
> (cherry picked from commit 5a4dc285002e1924dbc8c72d17481a3dbc4c0142)
> A typo was introduced during the conflict resolution while
> cherrypicking to 17.3.
> First things first, can we mitigate this? Would it be possible to get
> a 17.3.5 with this fixed ASAP? This can be fixed by either rolling
> back ad764e365beb8a119369b97f22225cb95fc7ea8c or by applying
> https://patchwork.freedesktop.org/patch/204260/ (obviously not applied
> to master as the issue did not occur there).
I'll do a 17.3.5 momentarily, including only the above fix.
> Secondly, I'd like to talk about process and how to prevent this in
> the future. Bugfix releases are supposed to be stable so downstream
> maintainers don't have to to deal with this kind of stuff happening,
> so I think that breaking radv pretty much completely is particularly
> egregious and we should look at how to prevent this happnening another
Sadly James' fix went below the radar since:
- it wasn't merged in master - understandably so
- I mistook his reply as some lovely emails that mesa-announce is
throwing at me
A few things come to mind:
- on my end - resolve the mesa-announce noise, ensure replies are highlighted
- having regular reply [to the RC email] with negative and positive
testing results will be great
- wire up some Vulkan games into the LunarG*/other test rig
I've been going through * since it's inception, as the only means of
checking non Intel hardware.
mesa-dev mailing list