Quoting Eric Engestrom (2018-02-27 04:12:37) > On Friday, 2018-02-23 16:49:14 -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-02-23 10:08:48) > > > The messages are basically the same as the ones in configure.ac > > > > > > Signed-off-by: Eric Engestrom <[email protected]> > > > --- > > > Sent out because it's as much as I could do before the weekend, and > > > before I try to figure out the last bits I'd love some confirmation that > > > this is what we want :) > > > --- > > > meson.build | 128 > > > ++++++++++++++++++++++++++++++++++++++++++++++++ > > > src/gallium/meson.build | 13 +++++ > > > 2 files changed, 141 insertions(+) > > > > > > diff --git a/meson.build b/meson.build > > > index 770fdc7e50653bcfa7c2..0c84d09c02322ed7a80b 100644 > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -1263,3 +1263,131 @@ env_test.set('NM', find_program('nm').path()) > > > subdir('include') > > > subdir('bin') > > > subdir('src') > > > + > > > + > > > +# > > > +# Output some configuration info for the user > > > +# > > > +message('') > > > +message(' prefix: ' + get_option('prefix')) > > > +message(' libdir: ' + join_paths(get_option('prefix'), > > > get_option('libdir'))) > > > +message(' includedir: ' + join_paths(get_option('prefix'), > > > get_option('includedir'))) > > > > I'd really like to avoid having millions of message() calls, what about: > > messsage(''' > > > > prefix: @0@ > > libdir: @1@ > > includedir: @2@ > > > > ... > > > > '''.format( > > ... > > )) > > I'll group where possible, but there's a lot of logic that can't be > cleanly put into .format() > > I'll apply all your other comments and send the actual patches when I'm > done; thanks for the feedback :) >
Could we at least use more ''' strings and less message calls? It's really clunky to me to call message over and over again. Dylan
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
