Reviewed-by: Alex Smith <[email protected]> On 1 March 2018 at 09:53, Samuel Pitoiset <[email protected]> wrote:
> This is just useless for two reasons: > 1) flush_bits is not set accordingly, so nothing will be flushed > in BeginQuery(). > 2) we always flush caches in EndCommandBuffer(), so if a reset > is done in a previous command buffer we are safe. > > Cc: Alex Smith <[email protected]> > Signed-off-by: Samuel Pitoiset <[email protected]> > --- > src/amd/vulkan/radv_cmd_buffer.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_ > buffer.c > index cfdc531acd..2b41baea3d 100644 > --- a/src/amd/vulkan/radv_cmd_buffer.c > +++ b/src/amd/vulkan/radv_cmd_buffer.c > @@ -1930,13 +1930,6 @@ VkResult radv_BeginCommandBuffer( > > cmd_buffer->status = RADV_CMD_BUFFER_STATUS_RECORDING; > > - /* Force cache flushes before starting a new query in case the > - * corresponding pool has been resetted from a different command > - * buffer. This is because we have to flush caches between reset > and > - * begin if the compute shader path has been used. > - */ > - cmd_buffer->pending_reset_query = true; > - > return result; > } > > -- > 2.16.2 > >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
