On Friday, 2018-03-23 17:44:21 +0000, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.co.uk> > > The currently we use the singular CHECK_HEADER combined with explicit > append to the DEFINES variable. That is a legacy misnomer, since it > requires us to add $DEFINES to every piece that we build. > > Using the plural version of the helper sets the HAVE_ macro for us, plus > ensures it's passed to the compiler - if config.h is available in there > (not in the case of mesa) otherwise on the command line. > > In hindsight, we should replace all the AC_CHECK_{FUNC,HEADER} instances > with the plural version (or even the _ONCE suffixed version) and drop > the DEFINES hacks. > > Fixes: cbee1bfb342 ("meson/configure: detect endian.h instead of trying > to guess when it's available") > Cc: Eric Engestrom <eric.engest...@imgtec.com>
Acked-by: Eric Engestrom <eric.engest...@imgtec.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105717 > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 36c56da787e..99805e0f2bf 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -865,7 +865,7 @@ fi > AC_HEADER_MAJOR > AC_CHECK_HEADER([xlocale.h], [DEFINES="$DEFINES -DHAVE_XLOCALE_H"]) > AC_CHECK_HEADER([sys/sysctl.h], [DEFINES="$DEFINES -DHAVE_SYS_SYSCTL_H"]) > -AC_CHECK_HEADER([endian.h], [DEFINES="$DEFINES -DHAVE_ENDIAN_H"]) > +AC_CHECK_HEADERS([endian.h]) > AC_CHECK_FUNC([strtof], [DEFINES="$DEFINES -DHAVE_STRTOF"]) > AC_CHECK_FUNC([mkostemp], [DEFINES="$DEFINES -DHAVE_MKOSTEMP"]) > AC_CHECK_FUNC([timespec_get], [DEFINES="$DEFINES -DHAVE_TIMESPEC_GET"]) > -- > 2.13.0 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev