Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net>

What driver is hitting this path? The !supports_ints path isn't used to my knowledge so if some driver has started using it, they're liable to find more bugs than just this one. :-)

On April 14, 2018 12:16:48 Erico Nunes <nunes.er...@gmail.com> wrote:

ir_binop_gequal needs to be converted to nir_op_sge when native integers
are not supported in the driver.
Otherwise it becomes no different than ir_binop_less after the
conversion.

Signed-off-by: Erico Nunes <nunes.er...@gmail.com>
---
src/compiler/glsl/glsl_to_nir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/glsl/glsl_to_nir.cpp b/src/compiler/glsl/glsl_to_nir.cpp
index 17d58acc4c..8e5e9c3491 100644
--- a/src/compiler/glsl/glsl_to_nir.cpp
+++ b/src/compiler/glsl/glsl_to_nir.cpp
@@ -1832,7 +1832,7 @@ nir_visitor::visit(ir_expression *ir)
         else
            result = nir_uge(&b, srcs[0], srcs[1]);
      } else {
-         result = nir_slt(&b, srcs[0], srcs[1]);
+         result = nir_sge(&b, srcs[0], srcs[1]);
      }
      break;
   case ir_binop_equal:
--
2.14.3

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev



_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to