On 02/28/2012 06:49 PM, Yuanhan Liu wrote:
Hi Brian,

comments?

Looks OK to me. I don't think there would be any harm in emitting the point size attribute if neither a vertex shader nor vertex program was enabled but GL_VERTEX_PROGRAM_POINT_SIZE_ARB was enabled.

Reviewed-by: Brian Paul <bri...@vmware.com>



Thanks,
Yuanhan Liu
On Thu, Feb 23, 2012 at 02:19:18PM +0800, Yuanhan Liu wrote:
We may specify the point size in a glsl vertex shader.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=46311
piglit: glsl-vs-point-size

NOTE: This is a candidate for stable release branches.

Signed-off-by: Yuanhan Liu<yuanhan....@linux.intel.com>
---
  src/mesa/tnl/t_context.c |    3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/mesa/tnl/t_context.c b/src/mesa/tnl/t_context.c
index 1ded44c..e38c0a3 100644
--- a/src/mesa/tnl/t_context.c
+++ b/src/mesa/tnl/t_context.c
@@ -151,8 +151,7 @@ _tnl_InvalidateState( struct gl_context *ctx, GLuint 
new_state )
     if (ctx->RenderMode == GL_FEEDBACK)
        tnl->render_inputs_bitset |= BITFIELD64_BIT(_TNL_ATTRIB_TEX0);

-   if (ctx->Point._Attenuated ||
-       (ctx->VertexProgram._Enabled&&  ctx->VertexProgram.PointSizeEnabled))
+   if (ctx->Point._Attenuated || ctx->VertexProgram.PointSizeEnabled)
        tnl->render_inputs_bitset |= BITFIELD64_BIT(_TNL_ATTRIB_POINTSIZE);

     /* check for varying vars which are written by the vertex program */
--
1.7.4.4

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to