On 03/05/18 02:58, Ilia Mirkin wrote:
On Wed, May 2, 2018 at 6:27 AM, Timothy Arceri <tarc...@itsqueeze.com> wrote:
---
  src/mapi/glapi/gen/apiexec.py | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mapi/glapi/gen/apiexec.py b/src/mapi/glapi/gen/apiexec.py
index b5e0ad4a179..d33cc85d47f 100644
--- a/src/mapi/glapi/gen/apiexec.py
+++ b/src/mapi/glapi/gen/apiexec.py
@@ -46,7 +46,7 @@ class exec_info():
          if compatibility is not None:
              assert isinstance(compatibility, int)
              assert compatibility >= 10
-            assert compatibility <= 30
+            assert compatibility <= 46

          if core is not None:
              assert isinstance(core, int)
@@ -70,7 +70,7 @@ functions = {
      "TexBuffer": exec_info(compatibility=20, core=31, es2=31),

      # OpenGL 3.2 / GL_OES_geometry_shader.
-    "FramebufferTexture": exec_info(core=32, es2=31),
+    "FramebufferTexture": exec_info(compatibility=32, core=32, es2=31),

Does it make sense to list out compat explicitly in the presence of
core? Are there any core functions that aren't available in compat
contexts of that version?

IMHO it's worth changing the exec_info class to say

if core and compatibility is None:
   compatibility = core

... or something along those lines.

If core and compatibility are none then compatibility = core is redundant. I'm I missing something?




      # OpenGL 4.0 / GL_ARB_shader_subroutines. Mesa only exposes this
      # extension with core profile.
--
2.17.0

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to