On 2018-05-08 01:54:13, Chris Wilson wrote: > Quoting Scott D Phillips (2018-05-08 01:30:45) > > A later patch will make use of this in other places. Also, remove > > dependency on undefined behavior of left-shifting a signed value. > > Can it find a home in src/intel/common/gen_gtt.h (or gen_vma.h, > gen_address.h)? > -Chris
That sounds good. If you also rename it to gen_canonical_address it will also help make the function name not so generic. (canonical sounds generic, but it is actually addressing some specific gen hardware trivia.) With that: Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
