On Fri, Jan 26, 2018 at 05:59:58PM -0800, Jason Ekstrand wrote:
> On CNL and above, CCS_E supports 1010102 formats and R11G11B10F. We had
> shut them off during early enabling because blorp_copy couldn't handle
> them. Now it can so we can turn them back on.
> ---
> src/intel/isl/isl_format.c | 24 ------------------------
> 1 file changed, 24 deletions(-)
Patches 27-29 are:
Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com>
>
> diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c
> index 793c84b..0eb7ae0 100644
> --- a/src/intel/isl/isl_format.c
> +++ b/src/intel/isl/isl_format.c
> @@ -545,30 +545,6 @@ isl_format_supports_ccs_e(const struct gen_device_info
> *devinfo,
> if (!format_info[format].exists)
> return false;
>
> - /* For simplicity, only report that a format supports CCS_E if blorp can
> - * perform bit-for-bit copies with an image of that format while
> compressed.
> - * This allows ISL users to avoid having to resolve the image before
> - * performing such a copy. We may want to change this behavior in the
> - * future.
> - *
> - * R11G11B10_FLOAT has no equivalent UINT format. Given how blorp_copy
> - * currently works, bit-for-bit copy operations are not possible without
> an
> - * intermediate resolve.
> - */
> - if (format == ISL_FORMAT_R11G11B10_FLOAT)
> - return false;
> -
> - /* blorp_copy currently doesn't support formats with different bit-widths
> - * per-channel. Until that support is added, report that these formats
> don't
> - * support CCS_E. FIXME: Add support for these formats.
> - */
> - if (format == ISL_FORMAT_B10G10R10A2_UNORM ||
> - format == ISL_FORMAT_B10G10R10A2_UNORM_SRGB ||
> - format == ISL_FORMAT_R10G10B10A2_UNORM ||
> - format == ISL_FORMAT_R10G10B10A2_UINT) {
> - return false;
> - }
> -
> return format_gen(devinfo) >= format_info[format].ccs_e;
> }
>
> --
> 2.5.0.400.gff86faf
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
