Hi Ilia;
On 05/09/2018 04:05 PM, Tapani Pälli wrote:
On 09.05.2018 14:39, Ilia Mirkin wrote:
On Wed, May 9, 2018 at 2:12 AM, Tapani Pälli <tapani.pa...@intel.com>
wrote:
Functionality already covered by ARB_texture_view, patch also
adds missing 'gles guard' for enums (added in f1563e6392).
Tested via arb_texture_view.*_gles3 tests and individual app
utilizing texture view with ETC2.
I only converted a few of the tests to work with GLES3 (it was nearly
2 years ago, so my recollection is hazy, but I think the remainder
required a lot more work). I think all or most of the tests in
arb_texture_view need GLES3 equivalents before we can be sure the
functionality is good to go. At the very least, someone should audit
the tests that were not converted to see what functionality is not
being tested. I definitely didn't feel like I was finished enough to
push the implementation in mesa at the time.
I took a look at some of them, one issue is that piglit-utils 'probe
texel' functions are not compatible with ES because they use
glGetTexImage, to have more test coverage I think we would need to have
ES compatible equivalent for those functions. Will check how it would work.
I've sent couple of patch to piglit mailing list that add 6 more test
cases. There are some tests left, some of them are problematic not
because of API but formats being used. Let me know if there are some
particular tests/API in addition to which I converted you might be
worried about.
Thanks;
// Tapani
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
