Reviewed-by: Dylan Baker <dy...@pnwbakers.com>
Quoting Eric Engestrom (2018-05-11 06:56:13) > `dep_valgrind != []` now (0.45) produces a warning that is quite explicit: > WARNING: Trying to compare values of different types (DependencyHolder, > list) using !=. > The result of this is undefined and will become a hard error in a future > Meson release. > > `dep_valgrind = []` used to be the recommended way to deal with > non-existant dependency, but these don't work with `.found()`, so now > the recommended way is to declare a impossible dependency, which > null_dep does for us in Mesa. > > In short, we don't need and shouldn't check for `!= []` anywhere anymore. > > Signed-off-by: Eric Engestrom <eric.engest...@intel.com> > --- > src/compiler/glsl/glcpp/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/glsl/glcpp/meson.build > b/src/compiler/glsl/glcpp/meson.build > index e6a3dc86753d9485c450..09d44ddd68777bca8029 100644 > --- a/src/compiler/glsl/glcpp/meson.build > +++ b/src/compiler/glsl/glcpp/meson.build > @@ -57,7 +57,7 @@ glcpp = executable( > > if with_tests > modes = ['unix', 'windows', 'oldmac', 'bizarro'] > - if dep_valgrind != [] and dep_valgrind.found() > + if dep_valgrind.found() > modes += ['valgrind'] > endif > > -- > Cheers, > Eric >
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
