It might be good to add some additional commentary in the commit message such as:
i965 advertises the 16-bit R and RG formats through eglQueryDmaBufFormatsEXT but falls over when a client tries to use or asks more information about such a format because driImageFormatToGLFormat returns MESA_FORMAT_NONE. Reviewed-by: Jason Ekstrand <[email protected]> Let's use this instead of patch 5/7 from the series I sent earlier. I'm still not sure I believe Daniel but advertising them shouldn't hurt. On Wed, Jun 6, 2018 at 10:36 AM, Lionel Landwerlin < [email protected]> wrote: > Found by Eero. > > v2: Add G16R16 formats (Lionel) > > v3: Fix G16R16 mapping to mesa format (Jason) > > Signed-off-by: Lionel Landwerlin <[email protected]> > Reviewed-by: Plamena Manolova <[email protected]> (v2) > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642 > --- > src/mesa/drivers/dri/common/dri_util.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/src/mesa/drivers/dri/common/dri_util.c > b/src/mesa/drivers/dri/common/dri_util.c > index a591dfcd7d2..d257cb644c8 100644 > --- a/src/mesa/drivers/dri/common/dri_util.c > +++ b/src/mesa/drivers/dri/common/dri_util.c > @@ -936,6 +936,22 @@ static const struct { > .image_format = __DRI_IMAGE_FORMAT_SARGB8, > .mesa_format = MESA_FORMAT_B8G8R8A8_SRGB, > }, > + { > + .image_format = __DRI_IMAGE_FORMAT_R16, > + .mesa_format = MESA_FORMAT_R_UNORM16, > + }, > + { > + .image_format = __DRI_IMAGE_FORMAT_R16, > + .mesa_format = MESA_FORMAT_L_UNORM16, > + }, > + { > + .image_format = __DRI_IMAGE_FORMAT_GR1616, > + .mesa_format = MESA_FORMAT_R16G16_UNORM, > + }, > + { > + .image_format = __DRI_IMAGE_FORMAT_GR1616, > + .mesa_format = MESA_FORMAT_L16A16_UNORM, > + }, > }; > > uint32_t > -- > 2.17.1 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
