On Friday, 2018-06-08 08:49:33 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-06-08 07:46:01) > > On Friday, 2018-06-08 15:38:41 +0100, Emil Velikov wrote: > > > On 8 June 2018 at 12:26, Eric Engestrom <[email protected]> wrote: > > > > Suggested-by: Emil Velikov <[email protected]> > > > > Signed-off-by: Eric Engestrom <[email protected]> > > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106861 > > > Fixes: ... > > > > Thanks; already added locally, didn't want to resend just for that :) > > > > > > > > > --- a/meson.build > > > > +++ b/meson.build > > > > @@ -1202,7 +1202,7 @@ if with_platform_wayland > > > > dep_wayland_client = dependency('wayland-client', version : '>=1.11') > > > > dep_wayland_server = dependency('wayland-server', version : '>=1.11') > > > > if with_egl > > > > - dep_wayland_egl = dependency('wayland-egl', version : '>=1.15') > > > > + dep_wayland_egl = dependency('wayland-egl-backend', version : '>= > > > > 3') > > > The dep_wayland_egl should be a header only dependency, alike > > > dep_va_headers. > > > > The pkg-config only provides a header include path anyway; is it worth the > > effort? > > (not so much code effort, but maintenance effort of having a special case > > here) > > Since the pkg_config only provides headers we could just call it *_headers :) > Otherwise I vote just leave it, I don't think it's worth trying to special > case > something that doesn't need to be, especially since it's such a pain to do so > until meson 0.46, when we get language support for headers-only dependencies
I ended up pushing the version with the clunky header-only hack (37eb56d239986e2e7ca1) a few minutes before your email :) I say we keep it as is for now, and drop the hack when we move to 0.46 in a few months :) > > Dylan > > > > > > > With that the patch is > > > Reviewed-by: Emil Velikov <[email protected]> > > > > Thanks :) > > > > > > > > Thanks > > > Emil _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
