Am Freitag, den 08.06.2018, 16:28 +0100 schrieb Emil Velikov: > On 8 June 2018 at 12:02, Gert Wollny <gw.foss...@gmail.com> wrote: > > From: Gert Wollny <gert.wol...@collabora.com> > > > > This warning is misleading: When a struct is partially initialized > > without > > assigning to the struture members by name, then the un-initialized > > fields > > will be zeroed out, and this warning will be issued (if enabled). > > If, on the > > other hand, the partial initialization is done by assigning to > > named members, > > the remaining structure elements may hold random data, but the > > warning is not > > issued. Since in Mesa the first approach to initialize structure > > elements is > > used very often, and it is usually assumed that the remaining > > elements are > > zeroed out, so heeding this warning would be counter-productive. > > > > v2: - add -Wno-missing-field-initializers to meson-build > > - fix empty line error > > (both Eric Engestrom) > > > > Reviewed-by: Marek Olšák <marek.ol...@amd.com> (v1) > > Signed-off-by: Gert Wollny <gert.wol...@collabora.com> > > --- > > resent to attach it to the proper thread in patchwork > > > > Out of curiosity: how many warnings are we walking about - is it > something like 20-50 or it's in the 100+ region?
With i965, swr, and intel vulkan it's about 300 unique warnings, with swr, r600, radeonsi, and OpenCL, I got 9000 (yes, three zeros). > > There's a small comment on 24/24, with that the series is > Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > > Please do not resent the whole series because if you agree with the > 24/24 comment. > > You've been around for a while and have ~70 patches merged. Might be > good idea to apply for commit access. I was already thinking about this, I was just wondering whether the move to gitlab would change the procedure. Best, Gert > https://www.freedesktop.org/wiki/AccountRequests/ > https://bugs.freedesktop.org/show_bug.cgi?id=99601 > > HTH > Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev